Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: chrome/browser/captive_portal/captive_portal_service.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_service.cc
diff --git a/chrome/browser/captive_portal/captive_portal_service.cc b/chrome/browser/captive_portal/captive_portal_service.cc
index d6a013c268acf9a64545fcbebf5f8894966c5930..01ec60e0ca5b4ccda9e4337a9804fbe94bea21f8 100644
--- a/chrome/browser/captive_portal/captive_portal_service.cc
+++ b/chrome/browser/captive_portal/captive_portal_service.cc
@@ -271,14 +271,10 @@ void CaptivePortalService::OnPortalDetectionCompleted(
OnResult(result);
}
-void CaptivePortalService::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
+void CaptivePortalService::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
DCHECK(CalledOnValidThread());
- DCHECK_EQ(chrome::NOTIFICATION_PREF_CHANGED, type);
- DCHECK_EQ(std::string(prefs::kAlternateErrorPagesEnabled),
- *content::Details<std::string>(details).ptr());
+ DCHECK_EQ(prefs::kAlternateErrorPagesEnabled, pref_name);
UpdateEnabledState();
}

Powered by Google App Engine
This is Rietveld 408576698