chrome/browser/prefs/pref_observer_mock.cc - Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/pref_observer_mock.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/prefs/pref_observer_mock.h"	5 #include "chrome/browser/prefs/pref_observer_mock.h"

6 #include "chrome/common/chrome_notification_types.h"	6 #include "chrome/common/chrome_notification_types.h"

7	7

8 PrefObserverMock::PrefObserverMock() {}	8 PrefObserverMock::PrefObserverMock() {}

9	9

10 PrefObserverMock::~PrefObserverMock() {}	10 PrefObserverMock::~PrefObserverMock() {}

11	11

12 void PrefObserverMock::Expect(const PrefService* prefs,	12 void PrefObserverMock::Expect(PrefServiceBase* prefs,

13 const std::string& pref_name,	13 const std::string& pref_name,

14 const Value* value) {	14 const Value* value) {

15 EXPECT_CALL(*this, Observe(int(chrome::NOTIFICATION_PREF_CHANGED),	15 EXPECT_CALL(*this, OnPreferenceChanged(prefs, pref_name))

16 content::Source<PrefService>(prefs),

17 Property(&content::Details<std::string>::ptr,

18 Pointee(pref_name))))

19 .With(PrefValueMatches(prefs, pref_name, value));	16 .With(PrefValueMatches(prefs, pref_name, value));

20 }	17 }

OLD	NEW