Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/browser/api/prefs/pref_member_unittest.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/api/prefs/pref_member.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/api/prefs/pref_member.h" 5 #include "chrome/browser/api/prefs/pref_member.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "chrome/browser/prefs/pref_value_store.h" 9 #include "chrome/browser/prefs/pref_value_store.h"
10 #include "chrome/common/chrome_notification_types.h" 10 #include "chrome/common/chrome_notification_types.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 void GetPrefValueOnIOThread() { 70 void GetPrefValueOnIOThread() {
71 value_ = pref_.GetValue(); 71 value_ = pref_.GetValue();
72 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 72 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
73 MessageLoop::QuitClosure()); 73 MessageLoop::QuitClosure());
74 } 74 }
75 75
76 BooleanPrefMember pref_; 76 BooleanPrefMember pref_;
77 bool value_; 77 bool value_;
78 }; 78 };
79 79
80 class PrefMemberTestClass : public content::NotificationObserver { 80 class PrefMemberTestClass : public PrefObserver {
81 public: 81 public:
82 explicit PrefMemberTestClass(PrefService* prefs) 82 explicit PrefMemberTestClass(PrefService* prefs)
83 : observe_cnt_(0), prefs_(prefs) { 83 : observe_cnt_(0), prefs_(prefs) {
84 str_.Init(kStringPref, prefs, this); 84 str_.Init(kStringPref, prefs, this);
85 } 85 }
86 86
87 virtual void Observe(int type, 87 virtual void OnPreferenceChanged(PrefServiceBase* service,
88 const content::NotificationSource& source, 88 const std::string& pref_name) OVERRIDE {
89 const content::NotificationDetails& details) { 89 EXPECT_EQ(service, prefs_);
90 DCHECK(chrome::NOTIFICATION_PREF_CHANGED == type); 90 EXPECT_EQ(pref_name, kStringPref);
91 PrefService* prefs_in = content::Source<PrefService>(source).ptr();
92 EXPECT_EQ(prefs_in, prefs_);
93 std::string* pref_name_in = content::Details<std::string>(details).ptr();
94 EXPECT_EQ(*pref_name_in, kStringPref);
95 EXPECT_EQ(str_.GetValue(), prefs_->GetString(kStringPref)); 91 EXPECT_EQ(str_.GetValue(), prefs_->GetString(kStringPref));
96 ++observe_cnt_; 92 ++observe_cnt_;
97 } 93 }
98 94
99 StringPrefMember str_; 95 StringPrefMember str_;
100 int observe_cnt_; 96 int observe_cnt_;
101 97
102 private: 98 private:
103 PrefService* prefs_; 99 PrefService* prefs_;
104 }; 100 };
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 prefs.SetBoolean(kBoolPref, true); 316 prefs.SetBoolean(kBoolPref, true);
321 317
322 ASSERT_TRUE(callback->FetchValue()); 318 ASSERT_TRUE(callback->FetchValue());
323 EXPECT_TRUE(callback->value()); 319 EXPECT_TRUE(callback->value());
324 320
325 callback->Destroy(); 321 callback->Destroy();
326 322
327 ASSERT_TRUE(callback->FetchValue()); 323 ASSERT_TRUE(callback->FetchValue());
328 EXPECT_TRUE(callback->value()); 324 EXPECT_TRUE(callback->value());
329 } 325 }
OLDNEW
« no previous file with comments | « chrome/browser/api/prefs/pref_member.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698