Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/ui/webui/options/media_galleries_handler.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_
7 7
8 #include "base/prefs/public/pref_change_registrar.h" 8 #include "base/prefs/public/pref_change_registrar.h"
9 #include "base/prefs/public/pref_observer.h"
9 #include "chrome/browser/ui/webui/options/options_ui.h" 10 #include "chrome/browser/ui/webui/options/options_ui.h"
10 #include "content/public/browser/notification_observer.h" 11 #include "content/public/browser/notification_observer.h"
11 #include "ui/base/dialogs/select_file_dialog.h" 12 #include "ui/base/dialogs/select_file_dialog.h"
12 13
13 namespace options { 14 namespace options {
14 15
15 // Handles messages related to adding or removing media galleries. 16 // Handles messages related to adding or removing media galleries.
16 class MediaGalleriesHandler : public OptionsPageUIHandler, 17 class MediaGalleriesHandler : public OptionsPageUIHandler,
18 public PrefObserver,
17 public ui::SelectFileDialog::Listener { 19 public ui::SelectFileDialog::Listener {
18 public: 20 public:
19 MediaGalleriesHandler(); 21 MediaGalleriesHandler();
20 virtual ~MediaGalleriesHandler(); 22 virtual ~MediaGalleriesHandler();
21 23
22 // OptionsPageUIHandler implementation. 24 // OptionsPageUIHandler implementation.
23 virtual void GetLocalizedValues(base::DictionaryValue* values) OVERRIDE; 25 virtual void GetLocalizedValues(base::DictionaryValue* values) OVERRIDE;
24 virtual void InitializePage() OVERRIDE; 26 virtual void InitializePage() OVERRIDE;
25 virtual void RegisterMessages() OVERRIDE; 27 virtual void RegisterMessages() OVERRIDE;
26 28
27 // SelectFileDialog::Listener implementation. 29 // SelectFileDialog::Listener implementation.
28 virtual void FileSelected(const FilePath& path, int index, void* params) 30 virtual void FileSelected(const FilePath& path, int index, void* params)
29 OVERRIDE; 31 OVERRIDE;
30 32
31 // NotificationObserver implementation. 33 // PrefObserver implementation.
32 virtual void Observe(int type, 34 virtual void OnPreferenceChanged(PrefServiceBase* service,
33 const content::NotificationSource& source, 35 const std::string& pref_name) OVERRIDE;
34 const content::NotificationDetails& details) OVERRIDE;
35 36
36 private: 37 private:
37 // Handles the "addNewGallery" message (no arguments). 38 // Handles the "addNewGallery" message (no arguments).
38 void HandleAddNewGallery(const base::ListValue* args); 39 void HandleAddNewGallery(const base::ListValue* args);
39 // Handles "forgetGallery" message. The first and only argument is the id of 40 // Handles "forgetGallery" message. The first and only argument is the id of
40 // the gallery. 41 // the gallery.
41 void HandleForgetGallery(const base::ListValue* args); 42 void HandleForgetGallery(const base::ListValue* args);
42 43
43 // Called when the list of known galleries has changed; updates the page. 44 // Called when the list of known galleries has changed; updates the page.
44 void OnGalleriesChanged(); 45 void OnGalleriesChanged();
45 46
46 PrefChangeRegistrar pref_change_registrar_; 47 PrefChangeRegistrar pref_change_registrar_;
47 48
48 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesHandler); 49 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesHandler);
49 }; 50 };
50 51
51 } // namespace options 52 } // namespace options
52 53
53 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_ 54 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698