base/prefs/public/pref_observer.h - Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/prefs/public/pref_observer.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_PREFS_PUBLIC_PREF_OBSERVER_H_

	6 #define BASE_PREFS_PUBLIC_PREF_OBSERVER_H_

	7

	8 #include <string>

	9

	10 class PrefServiceBase;

	11

	12 class PrefObserver {

	13 public:
	Mattias Nissler (ping if slow) 2012/10/30 13:37:07 should have a comment, and you should put a TODO s should have a comment, and you should put a TODO saying that we'd like to replace that by a base::Callback-style interface.
	14 virtual void OnPreferenceChanged(PrefServiceBase* service,

	15 const std::string& pref_name) = 0;
	Mattias Nissler (ping if slow) 2012/10/30 09:09:30 Any reason to not use base::Callback<void(PrefServ Any reason to not use base::Callback<void(PrefServiceBase*, const std::string&) for this purpose? I guess this would also allow for reducing lots of complexity in the consumers, because they can drop switch(pref_name)-style code and have dedicated handlers for the different events.
	16 };

	17

	18 #endif // BASE_PREFS_PUBLIC_PREF_OBSERVER_H_

OLD	NEW