Issue 113445: Add multiple generations (5) to the script compilation cache...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113445: Add multiple generations (5) to the script compilation cache... (Closed)

Created:
11 years, 7 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add multiple generations (5) to the script compilation cache to allow scripts that are used alot to survive a number of GCs in the compilation cache. Committed: http://code.google.com/p/v8/source/detail?r=1955

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -34 lines)			Patch
M	src/compilation-cache.h	View	2 chunks	+3 lines, -3 lines	1 comment	Download
M	src/compilation-cache.cc	View	3 chunks	+61 lines, -31 lines	0 comments	Download
M	test/cctest/test-api.cc	View	5 chunks	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 7 months ago (2009-05-15 06:43:28 UTC) #2

LGTM

http://codereview.chromium.org/113445/diff/1/4
File src/compilation-cache.h (right):

http://codereview.chromium.org/113445/diff/1/4#newcode97
Line 97: // just clear the cache but we should consider are more
Update the comment?

Expand Messages | Collapse Messages