Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 113433: Fix memory leak in corrupt JPEG decoding. (Closed)

Created:
11 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix memory leak in corrupt JPEG decoding. BUG=10945 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16352

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M base/gfx/jpeg_codec.cc View 1 4 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/suppressions.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
"gotcha!" (it wasn't obvious because it was in an error handler)
11 years, 7 months ago (2009-05-15 00:11:03 UTC) #1
Lei Zhang
Upon closer look, this is happening because we're in undefined behavior territory. From man longjmp: ...
11 years, 7 months ago (2009-05-15 21:26:49 UTC) #2
dank
11 years, 7 months ago (2009-05-19 00:35:56 UTC) #3
LGTM, though I couldn't tell at first glance whether the
rest of the function is safe.  (I wonder if one shouldn't
avoid using local variables in the same function as longjmp
alltogether... or mark them all volatile.)

Powered by Google App Engine
This is Rietveld 408576698