Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 11343: Only remove -Wall from $CXXFLAGS on Linux, not on Mac. Mac's tool... (Closed)

Created:
12 years, 1 month ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
tc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Only remove -Wall from $CXXFLAGS on Linux, not on Mac. Mac's tool chain doesn't add -Wall, leading to an exception and stack trace. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/base_lib.scons View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
sgk
12 years, 1 month ago (2008-11-21 05:16:27 UTC) #1
TBR: tony

Powered by Google App Engine
This is Rietveld 408576698