Histogram type support in HistogramBase and remove SetRangeDescription function

base/metrics/histogram_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_base.h"
 
 #include <climits>
 
+#include "base/logging.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 
 namespace base {
 
+std::string HistogramTypeName(HistogramType type) {
+  switch(type) {
+    case HISTOGRAM:
+      return "HISTOGRAM";
+      break;
+    case LINEAR_HISTOGRAM:
+      return "LINEAR_HISTOGRAM";
+      break;
+    case BOOLEAN_HISTOGRAM:
+      return "BOOLEAN_HISTOGRAM";
+      break;
+    case CUSTOM_HISTOGRAM:
+      return "CUSTOM_HISTOGRAM";
+      break;
+    case SPARSE_HISTOGRAM:
+      return "SPARSE_HISTOGRAM";
+      break;
+    default:
+      NOTREACHED();
+      break;

[Ilya Sherman, 2012/10/31 00:35:19]

nit: No need for any break stmts in this switch, since each case has a return
stmt, except for the default case which is the last case.

[kaiwang, 2012/10/31 01:12:56]

Done.

+  }
+  return "UNKNOWN";
+}
+
 const HistogramBase::Sample HistogramBase::kSampleType_MAX = INT_MAX;
 
 HistogramBase::HistogramBase(const std::string& name)
     : histogram_name_(name),
       flags_(kNoFlags) {}
 
 HistogramBase::~HistogramBase() {}
 
 void HistogramBase::SetFlags(int32 flags) {
   flags_ |= flags;
@@ skipping 14 matching lines @@
   DictionaryValue root;
   root.SetString("name", histogram_name());
   root.SetInteger("count", count);
   root.SetInteger("flags", flags());
   root.Set("params", parameters.release());
   root.Set("buckets", buckets.release());
   serializer.Serialize(root);
 }
 
 }  // namespace base