Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 11342060: Histogram type support in HistogramBase and remove SetRangeDescription function (Closed)

Created:
8 years, 1 month ago by kaiwang
Modified:
8 years, 1 month ago
CC:
chromium-reviews, MAD, sadrul, jar (doing other things), cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, gavinp+disk_chromium.org
Visibility:
Public.

Description

Histogram type support in HistogramBase and remove SetRangeDescription function BUG=139612 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165116

Patch Set 1 #

Total comments: 13

Patch Set 2 : address comments #

Patch Set 3 : Fix compiling error #

Patch Set 4 : Remove "using" from metrics.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -132 lines) Patch
M base/message_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/metrics/histogram.h View 1 7 chunks +17 lines, -28 lines 0 comments Download
M base/metrics/histogram.cc View 1 14 chunks +42 lines, -62 lines 0 comments Download
M base/metrics/histogram_base.h View 1 3 chunks +19 lines, -2 lines 0 comments Download
M base/metrics/histogram_base.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M base/metrics/sparse_histogram.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/metrics/sparse_histogram.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/metrics/metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics/metrics.cc View 1 2 3 8 chunks +18 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/metrics/metrics_apitest.cc View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M net/disk_cache/stats_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
kaiwang
8 years, 1 month ago (2012-10-31 00:16:43 UTC) #1
Ilya Sherman
LGTM http://codereview.chromium.org/11342060/diff/1/base/metrics/histogram.cc File base/metrics/histogram.cc (left): http://codereview.chromium.org/11342060/diff/1/base/metrics/histogram.cc#oldcode196 base/metrics/histogram.cc:196: DCHECK_NE(NOT_VALID_IN_RENDERER, histogram.histogram_type()); Please double-check with Jim that this ...
8 years, 1 month ago (2012-10-31 00:35:19 UTC) #2
kaiwang
http://codereview.chromium.org/11342060/diff/1/base/metrics/histogram.cc File base/metrics/histogram.cc (right): http://codereview.chromium.org/11342060/diff/1/base/metrics/histogram.cc#newcode644 base/metrics/histogram.cc:644: if (descriptions != NULL) { On 2012/10/31 00:35:19, Ilya ...
8 years, 1 month ago (2012-10-31 01:12:56 UTC) #3
kaiwang
Reviewers, please help to review the following dirs: jar: base yoz: chrome/browser/extensions rvargas: net/disk_cache Thanks ...
8 years, 1 month ago (2012-10-31 01:16:17 UTC) #4
Yoyo Zhou
LGTM for extensions, but please remove using statements from metrics.cc On Oct 30, 2012 6:16 ...
8 years, 1 month ago (2012-10-31 01:38:48 UTC) #5
jar (doing other things)
lgtm
8 years, 1 month ago (2012-10-31 01:40:18 UTC) #6
rvargas (doing something else)
net lgtm
8 years, 1 month ago (2012-10-31 02:07:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11342060/12001
8 years, 1 month ago (2012-10-31 02:38:05 UTC) #8
kaiwang
Thanks for all of your quick reviews! Submitting...
8 years, 1 month ago (2012-10-31 02:38:34 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-10-31 06:20:27 UTC) #10
Change committed as 165116

Powered by Google App Engine
This is Rietveld 408576698