Populate versions on individual nodes in sync model and native bookmark model.

sync/internal_api/sync_manager_impl.h

Index: sync/internal_api/sync_manager_impl.h
diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h
index 53b882e6177cf5d5ad7bce387d37865a6df23090..d87612c1b4fff270772ba6c7a9f90537a5741504 100644
--- a/sync/internal_api/sync_manager_impl.h
+++ b/sync/internal_api/sync_manager_impl.h
@@ -163,10 +163,12 @@ class SyncManagerImpl : public SyncManager,
       syncable::BaseTransaction* trans) OVERRIDE;
   virtual void HandleCalculateChangesChangeEventFromSyncApi(
       const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
-      syncable::BaseTransaction* trans) OVERRIDE;
+      syncable::BaseTransaction* trans,
+      std::vector<int64>* entry_changed) OVERRIDE;
   virtual void HandleCalculateChangesChangeEventFromSyncer(
       const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
-      syncable::BaseTransaction* trans) OVERRIDE;
+      syncable::BaseTransaction* trans,
+      std::vector<int64>* entry_changed) OVERRIDE;
 
   // InvalidationHandler implementation.
   virtual void OnInvalidatorStateChange(InvalidatorState state) OVERRIDE;
@@ -221,8 +223,6 @@ class SyncManagerImpl : public SyncManager,
       const syncable::EntryKernelMutation& mutation,
       Cryptographer* cryptographer) const;
 
-  bool ChangeBuffersAreEmpty();
-
   // Open the directory named with username_for_share
   bool OpenDirectory();
 
@@ -330,12 +330,13 @@ class SyncManagerImpl : public SyncManager,
   AllStatus allstatus_;
 
   // Each element of this array is a store of change records produced by

[Nicolas Zea, 2012/11/02 21:02:25]

Update comment. No longer an array, and now stored in tree order.

[haitaol1, 2012/11/02 22:58:18]

Done.

-  // HandleChangeEvent during the CALCULATE_CHANGES step.  The changes are
-  // segregated by model type, and are stored here to be processed and
-  // forwarded to the observer slightly later, at the TRANSACTION_ENDING
-  // step by HandleTransactionEndingChangeEvent. The list is cleared in the
-  // TRANSACTION_COMPLETE step by HandleTransactionCompleteChangeEvent.
-  ChangeReorderBuffer change_buffers_[MODEL_TYPE_COUNT];
+  // HandleChangeEventFromSyncer during the CALCULATE_CHANGES step. The changes
+  // are grouped by model type, and are stored here to be forwarded to the
+  // observer slightly later, at the TRANSACTION_ENDING step by
+  // HandleTransactionEndingChangeEvent. The list is cleared after observer
+  // finishes processing.
+  typedef std::map<int, ImmutableChangeRecordList> ChangeRecordMap;

[Nicolas Zea, 2012/11/02 21:02:25]

why not have ModelType as the key?

[haitaol1, 2012/11/02 22:58:18]

Because in HandleCalculateChangesChangeEventFromSyncer() I have:
for (int i = FIRST_REAL_MODEL_TYPE; i < MODEL_TYPE_COUNT; ++i) {
  ... change_records_[i] ...
}
can't make i to be of type ModelType because then ++i is not allowed. And looks
a little awkward to cast i to ModelType several times.


On 2012/11/02 21:02:25, Nicolas Zea wrote:

+  ChangeRecordMap change_records_;
 
   SyncManager::ChangeDelegate* change_delegate_;