Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/sync/glue/bookmark_change_processor.h

Issue 11341048: Populate versions on individual nodes in sync model and native bookmark model. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore heap unallocatability of write transaction Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_
6 #define CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 std::vector<unsigned char>* dst); 157 std::vector<unsigned char>* dst);
158 158
159 // Remove the sync node corresponding to |node|. It shouldn't have 159 // Remove the sync node corresponding to |node|. It shouldn't have
160 // any children. 160 // any children.
161 void RemoveOneSyncNode(syncer::WriteTransaction* trans, 161 void RemoveOneSyncNode(syncer::WriteTransaction* trans,
162 const BookmarkNode* node); 162 const BookmarkNode* node);
163 163
164 // Remove all the sync nodes associated with |node| and its children. 164 // Remove all the sync nodes associated with |node| and its children.
165 void RemoveSyncNodeHierarchy(const BookmarkNode* node); 165 void RemoveSyncNodeHierarchy(const BookmarkNode* node);
166 166
167 // Update transaction version of |model| and |node| to if sync model gets a
168 // new version.
169 void UpdateVersion(int64 old_version,
tim (not reviewing) 2012/11/01 18:31:36 nit - UpdateTransactionVersion to keep the naming
haitaol1 2012/11/02 17:57:11 Done.
170 BookmarkModel* model,
171 const std::vector<const BookmarkNode*>& nodes);
172
167 // The bookmark model we are processing changes from. Non-NULL when 173 // The bookmark model we are processing changes from. Non-NULL when
168 // |running_| is true. 174 // |running_| is true.
169 BookmarkModel* bookmark_model_; 175 BookmarkModel* bookmark_model_;
170 176
171 // The two models should be associated according to this ModelAssociator. 177 // The two models should be associated according to this ModelAssociator.
172 BookmarkModelAssociator* model_associator_; 178 BookmarkModelAssociator* model_associator_;
173 179
174 DISALLOW_COPY_AND_ASSIGN(BookmarkChangeProcessor); 180 DISALLOW_COPY_AND_ASSIGN(BookmarkChangeProcessor);
175 }; 181 };
176 182
177 } // namespace browser_sync 183 } // namespace browser_sync
178 184
179 #endif // CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_ 185 #endif // CHROME_BROWSER_SYNC_GLUE_BOOKMARK_CHANGE_PROCESSOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698