Animation changed to fade out on Launcher related bubbles.

Animation changed to fade out on Launcher related bubbles.


BUG=137285
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165221

[Harry McCleave, 2012-10-30 01:48:12]

Please take a look when you get the chance.

http://codereview.chromium.org/11341034/diff/1/ash/system/tray/tray_bubble_wr...
File ash/system/tray/tray_bubble_wrapper.cc (right):

http://codereview.chromium.org/11341034/diff/1/ash/system/tray/tray_bubble_wr...
ash/system/tray/tray_bubble_wrapper.cc:27:
tray_->InitializeBubbleAnimations(bubble_widget_);
Am I missing something of importance here as to why this was called after show?

[sky, 2012-10-30 16:07:05]

LGTM

[xiyuan, 2012-10-30 16:49:00]

LGTM

http://codereview.chromium.org/11341034/diff/1/ash/system/tray/tray_bubble_wr...
File ash/system/tray/tray_bubble_wrapper.cc (right):

http://codereview.chromium.org/11341034/diff/1/ash/system/tray/tray_bubble_wr...
ash/system/tray/tray_bubble_wrapper.cc:27:
tray_->InitializeBubbleAnimations(bubble_widget_);
On 2012/10/30 01:48:12, Harry McCleave wrote:
> Am I missing something of importance here as to why this was called after
show?

Can you be more specific? You mean it is called after SystemTray::ShowItem
returns?

[commit-bot: I haz the power, 2012-10-30 17:25:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/11341034/1

[commit-bot: I haz the power, 2012-10-30 17:25:02]

Failed to apply patch for ash/system/tray/tray_bubble_wrapper.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/system/tray/tray_bubble_wrapper.cc
  Hunk #1 FAILED at 24.
  1 out of 1 hunk FAILED -- saving rejects to file
ash/system/tray/tray_bubble_wrapper.cc.rej

Patch:       ash/system/tray/tray_bubble_wrapper.cc
Index: ash/system/tray/tray_bubble_wrapper.cc
diff --git a/ash/system/tray/tray_bubble_wrapper.cc
b/ash/system/tray/tray_bubble_wrapper.cc
index
5e92a846f10fa0e9d8be6f0c8ab44c6413b3f233..c5652c6075a79a277e8f209bcbc5dbd2826be0c3
100644
--- a/ash/system/tray/tray_bubble_wrapper.cc
+++ b/ash/system/tray/tray_bubble_wrapper.cc
@@ -24,8 +24,8 @@ TrayBubbleWrapper::TrayBubbleWrapper(TrayBackgroundView* tray,
   bubble_widget_->GetNativeView()->
       SetProperty(internal::kStayInSameRootWindowKey, true);
 
-  bubble_view_->InitializeAndShowBubble();
   tray_->InitializeBubbleAnimations(bubble_widget_);
+  bubble_view_->InitializeAndShowBubble();
 
   tray_event_filter_.reset(new TrayEventFilter(this));
 }

[commit-bot: I haz the power, 2012-10-31 17:38:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/11341034/8001

[commit-bot: I haz the power, 2012-10-31 20:48:14]

Change committed as 165221