Chrome remote control multi-page tests: Enable printing out histograms.

build/android/pylib/perf_tests_helper.py

Index: build/android/pylib/perf_tests_helper.py
diff --git a/build/android/pylib/perf_tests_helper.py b/build/android/pylib/perf_tests_helper.py
index c0a3ee413d80d5ed924538d1ddab86b377ea4016..e50d37028d11a7ad24e1b0c3e611b55fdd2b8cf8 100644
--- a/build/android/pylib/perf_tests_helper.py
+++ b/build/android/pylib/perf_tests_helper.py
@@ -5,12 +5,15 @@
 import re
 
 import android_commands
+import json
 import math
 
 # Valid values of result type.
 RESULT_TYPES = {'unimportant': 'RESULT ',
                 'default': '*RESULT ',
-                'informational': ''}
+                'informational': '',
+                'unimportant-histogram': 'HISTOGRAM ',
+                'histogram': '*HISTOGRAM '}
 
 
 def _EscapePerfResult(s):
@@ -20,6 +23,30 @@ def _EscapePerfResult(s):
   return re.sub(':|=', '_', s[:40])
 
 
+def GeomMeanAndStdDevFromHistogram(histogram_json):
+  histogram = json.loads(histogram_json)
+  count = 0
+  sum_of_logs = 0
+  for bucket in histogram['buckets']:
+    if 'high' in bucket:
+      bucket['mean'] = (bucket['low'] + bucket['high']) / 2.0
+    else:
+      bucket['mean'] = bucket['low']
+    if bucket['mean'] > 0:
+      sum_of_logs += math.log(bucket['mean']) * bucket['count']
+      count += bucket['count']
+
+  if count == 0:
+    return 0.0, 0.0
+
+  sum_of_squares = 0
+  geom_mean = math.exp(sum_of_logs / count)
+  for bucket in histogram['buckets']:
+    if bucket['mean'] > 0:
+      sum_of_squares += (bucket['mean'] - geom_mean) ** 2 * bucket['count']

[bulach, 2012/10/30 18:46:28]

not sure if this would be any clearer, feel free to ignore... :)

sum_of_squares = sum((b['mean'] - geom_mean) ** 2 * b['count']
    for b in histogram['buckets'] if b['mean'] > 0)

[marja, 2012/10/31 09:15:59]

Discussed this offline: This code is copied -> decided to leave it as is, to
make it easier to merge them later..

+  return geom_mean, math.sqrt(sum_of_squares / count)
+
+
 def PrintPerfResult(measurement, trace, values, units, result_type='default',
                     print_to_stdout=True):
   """Prints numerical data to stdout in the format required by perf tests.
@@ -43,22 +70,29 @@ def PrintPerfResult(measurement, trace, values, units, result_type='default',
   """
   assert result_type in RESULT_TYPES, 'result type: %s is invalid' % result_type
 
-  assert isinstance(values, list)
-  assert len(values)
-  assert '/' not in measurement
-  avg = None
-  sd = None
-  if len(values) > 1:
-    try:
-      value = '[%s]' % ','.join([str(v) for v in values])
-      avg = sum([float(v) for v in values]) / len(values)
-      sqdiffs = [(float(v) - avg) ** 2 for v in values]
-      variance = sum(sqdiffs) / (len(values) - 1)
-      sd = math.sqrt(variance)
-    except ValueError:
-      value = ", ".join(values)
+  if result_type in ['unimportant', 'default', 'informational']:
+    assert isinstance(values, list)
+    assert len(values)
+    assert '/' not in measurement
+    avg = None
+    sd = None
+    if len(values) > 1:
+      try:
+        value = '[%s]' % ','.join([str(v) for v in values])
+        avg = sum([float(v) for v in values]) / len(values)
+        sqdiffs = [(float(v) - avg) ** 2 for v in values]
+        variance = sum(sqdiffs) / (len(values) - 1)
+        sd = math.sqrt(variance)
+      except ValueError:
+        value = ", ".join(values)
+    else:
+      value = values[0]

[bulach, 2012/10/30 18:46:28]

maybe split 74-89 into GeomMeandAndStdDevFromList ?

[marja, 2012/10/31 09:15:59]

Done.

   else:
     value = values[0]
+    # We can't print the units, otherwise parsing the histogram json output
+    # can't be parsed easily.
+    units = ''
+    avg, sd = GeomMeanAndStdDevFromHistogram(value)
 
   trace_name = _EscapePerfResult(trace)
   output = '%s%s: %s%s%s %s' % (