Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 113393: Optimize the scope creation code by lazily allocating the hash maps... (Closed)

Created:
11 years, 7 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Optimize the scope creation code by lazily allocating the hash maps for dynamic variables (only do it for the scopes that need them). Committed: http://code.google.com/p/v8/source/detail?r=1942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M src/hashmap.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.h View 3 chunks +18 lines, -4 lines 0 comments Download
M src/scopes.cc View 4 chunks +9 lines, -24 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years, 7 months ago (2009-05-14 06:57:12 UTC) #1
Mads Ager (chromium)
11 years, 7 months ago (2009-05-14 07:03:01 UTC) #2
LGTM, nice cleanup as well.

Powered by Google App Engine
This is Rietveld 408576698