Issue 11338025: sync: reland sync scheduler job ownership refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11338025: sync: reland sync scheduler job ownership refactoring (Closed)

Created:
8 years, 1 month ago by tim (not reviewing)

Modified:
8 years, 1 month ago

Reviewers:

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: reland sync scheduler job ownership refactoring There are zero changes from the original review at https://codereview.chromium.org/10917234/ in this patch.

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1092 lines, -567 lines)			Patch
M	sync/engine/sync_scheduler.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.h	View	8 chunks	+51 lines, -75 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.cc	View	27 chunks	+356 lines, -341 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	14 chunks	+36 lines, -13 lines	0 comments	Download
M	sync/engine/sync_scheduler_whitebox_unittest.cc	View	13 chunks	+25 lines, -30 lines	0 comments	Download
A	sync/engine/sync_session_job.h	View	1 chunk	+124 lines, -0 lines	0 comments	Download
A	sync/engine/sync_session_job.cc	View	1 chunk	+184 lines, -0 lines	0 comments	Download
A	sync/engine/sync_session_job_unittest.cc	View	1 chunk	+239 lines, -0 lines	0 comments	Download
M	sync/engine/syncer.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sync/engine/syncer.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	sync/engine/syncer_unittest.cc	View	3 chunks	+7 lines, -8 lines	0 comments	Download
M	sync/internal_api/js_sync_manager_observer_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sync/internal_api/public/sessions/model_neutral_state.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/sessions/model_neutral_state.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/sessions/sync_session_snapshot.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	sync/internal_api/public/sessions/sync_session_snapshot.cc	View	4 chunks	+1 line, -8 lines	0 comments	Download
M	sync/internal_api/public/util/syncer_error.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sync/sessions/session_state_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sync/sessions/sync_session.h	View	4 chunks	+10 lines, -29 lines	0 comments	Download
M	sync/sessions/sync_session.cc	View	5 chunks	+16 lines, -42 lines	0 comments	Download
M	sync/sessions/sync_session_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/sessions/test_util.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	sync/sync.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download