Handle audio device changes on Mac (Take 2).

media/audio/mac/audio_manager_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_AUDIO_MAC_AUDIO_MANAGER_MAC_H_
 #define MEDIA_AUDIO_MAC_AUDIO_MANAGER_MAC_H_
 
 #include "base/basictypes.h"
+#include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "media/audio/audio_manager_base.h"
 
 namespace media {
 
+class AudioDeviceListenerMac;
+
 // Mac OS X implementation of the AudioManager singleton. This class is internal
 // to the audio output and only internal users can call methods not exposed by
 // the AudioManager class.
 class MEDIA_EXPORT AudioManagerMac : public AudioManagerBase {
  public:
   AudioManagerMac();
 
   // Implementation of AudioManager.
   virtual bool HasAudioOutputDevices() OVERRIDE;
   virtual bool HasAudioInputDevices() OVERRIDE;
   virtual void GetAudioInputDeviceNames(media::AudioDeviceNames* device_names)
       OVERRIDE;
 
   // Implementation of AudioManagerBase.
   virtual AudioOutputStream* MakeLinearOutputStream(
       const AudioParameters& params) OVERRIDE;
   virtual AudioOutputStream* MakeLowLatencyOutputStream(
       const AudioParameters& params) OVERRIDE;
   virtual AudioInputStream* MakeLinearInputStream(
       const AudioParameters& params, const std::string& device_id) OVERRIDE;
   virtual AudioInputStream* MakeLowLatencyInputStream(
       const AudioParameters& params, const std::string& device_id) OVERRIDE;
 
  protected:
   virtual ~AudioManagerMac();
 
+  // Implementation of AudioManager.
+  virtual void InitializeOnAudioThread() OVERRIDE;

[scherkus (not reviewing), 2012/10/31 23:17:22]

silliness alert!

Initialize() is an empty virtual provided by AMB + called by
AudioManager::Create()

Destruct is handled by the OS-specific AM impl

Seeing as GetMessageLoop() is guaranteed to be valid inside of an AMImpl how
about we move Initialize to be OS-specific AM impl and remove the PostTask()
from AM::Create?

[DaleCurtis, 2012/11/01 00:16:33]

I don't know how that would work? You can't post a task to the message loop on
another thread using "this" during construction. That was the original design
and that was why we had to move InitializeOnAudioThread() to AM::Create().

[scherkus (not reviewing), 2012/11/01 00:47:48]

I believe you're referring to https://chromiumcodereview.appspot.com/11260002/

In that case you were posting a task from inside the non-concrete
AudioManagerBase ctor but as a result introduced a race as the subclass' ctor
hadn't executed yet.

If you post a task using |this| inside of a concrete ctor (e.g., AMLinux, AMWin)
it's functionally the same as executing it post-concrete-ctor as
AudioManager::Create().

+
  private:
+  void DestructOnAudioThread();
+
+  // Listens for output device changes.
+  base::Closure listener_cb_;
+  scoped_ptr<AudioDeviceListenerMac> output_device_listener_;
+
   DISALLOW_COPY_AND_ASSIGN(AudioManagerMac);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_AUDIO_MAC_AUDIO_MANAGER_MAC_H_