Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 113375: Do not map Windows certificate errors returned by Schannel's... (Closed)

Created:
11 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

If Schannel's InitializeSecurityContext calls return certificate errors, do not map them to our (server) certificate errors because the errors are referring to the (missing) client certificate. If we incorrectly handle them as server certificate errors, we will crash because we can't get the server certificate from Schannel when the handshake fails. Fumitoshi Ukai of Google tracked down the bug and proposed an alternative fix. R=rvargas,ukai BUG=http://crbug.com/11646 TEST=Visit https://www.cdep.ro/. Chromium should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16026

Patch Set 1 #

Patch Set 2 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M net/base/ssl_client_socket_win.cc View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
Ricardo, please review this changelist. Fumitoshi, this is just FYI. Thanks for tracking down the ...
11 years, 7 months ago (2009-05-13 23:49:54 UTC) #1
rvargas (doing something else)
11 years, 7 months ago (2009-05-14 00:34:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698