Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 113354: Add more presubmit support. Add PRESUBMIT.py to depot_tools.... (Closed)

Created:
11 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add more presubmit support. Add PRESUBMIT.py to depot_tools. Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -28 lines) Patch
A PRESUBMIT.py View 1 chunk +38 lines, -0 lines 0 comments Download
M presubmit_support.py View 4 chunks +4 lines, -4 lines 0 comments Download
A tests/__init__.py View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 11 chunks +28 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 7 months ago (2009-05-13 18:00:57 UTC) #1
sgk
lgtm (rubber-stamp on the False => True arguments)
11 years, 7 months ago (2009-05-15 05:14:26 UTC) #2
M-A Ruel
11 years, 7 months ago (2009-05-15 12:40:02 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698