Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 113335: Add optional 'ids' parameter to 'scripts' request (Closed)

Created:
11 years, 7 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add parameter that allows to request data for scripts by their ids. It's going to be used e.g. to request script sources by their ids. Committed: http://code.google.com/p/v8/source/detail?r=1941

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M src/debug-delay.js View 1 2 4 chunks +18 lines, -0 lines 0 comments Download
M test/mjsunit/debug-scripts-request.js View 1 2 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 7 months ago (2009-05-13 12:48:17 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/113335/diff/1003/1004 File test/mjsunit/debug-scripts-request.js (right): http://codereview.chromium.org/113335/diff/1003/1004#newcode69 Line 69: var request = '{' + base_request + ...
11 years, 7 months ago (2009-05-13 14:19:52 UTC) #2
yurys
11 years, 7 months ago (2009-05-14 06:34:27 UTC) #3
http://codereview.chromium.org/113335/diff/1003/1004
File test/mjsunit/debug-scripts-request.js (right):

http://codereview.chromium.org/113335/diff/1003/1004#newcode69
Line 69: var request = '{' + base_request + '}'
On 2009/05/13 14:19:53, Søren Gjesse wrote:
> Please move these three lines below the 'testArguments' stuff to have the
> response closer to the new test code that uses it.
> 
> var request = '{' + base_request + '}'
> var response = safeEval(dcp.processDebugJSONRequest(request));
> assertTrue(response.success);
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698