Issue 113334: X64: Added dummy definitions of needed functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113334: X64: Added dummy definitions of needed functions. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee

CC:
v8-dev

Visibility:
Public.

Description

X64: Added dummy definitions of needed functions. All functions added in assembler-x64.cc. They should be distributed to where they belong when they are implemented.

Patch Set 1 #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+547 lines, -0 lines)			Patch
	M	src/x64/assembler-x64.cc	View		1 chunk	+547 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Added a quikc-and-dirty implementation of the missing functions.

11 years, 7 months ago (2009-05-13 12:30:48 UTC) #1

Dean McNamee

11 years, 7 months ago (2009-05-13 12:33:09 UTC) #2

Ok, I am surprised you need USE() for parameters.  I didn't check all of them,
but some of them are definitely wrong.

Thanks

http://codereview.chromium.org/113334/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/113334/diff/1/2#newcode168
Line 168: USE(a);
this is wrong.

http://codereview.chromium.org/113334/diff/1/2#newcode252
Line 252: USE(a);
wrong

http://codereview.chromium.org/113334/diff/1/2#newcode583
Line 583: 
tailing line :)

Expand Messages | Collapse Messages