Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 113332: Make the android arm sigcontext structure match glibc. (Closed)

Created:
11 years, 7 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Adjust for differences in the arm signal structures between glibc versions.

Patch Set 1 #

Patch Set 2 : glibc version :\ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/platform-linux.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dean McNamee
Hey Erik, Can you make sure this works ok on the Android build? I think ...
11 years, 7 months ago (2009-05-13 10:44:50 UTC) #1
Erik Corry
This doesn't work for our Debian non-EABI platform :-(
11 years, 7 months ago (2009-05-13 11:11:45 UTC) #2
Dean McNamee
On 2009/05/13 11:11:45, Erik Corry wrote: > This doesn't work for our Debian non-EABI platform ...
11 years, 7 months ago (2009-05-13 11:16:18 UTC) #3
Dean McNamee
11 years, 7 months ago (2009-05-13 12:54:52 UTC) #4
On 2009/05/13 11:16:18, Dean McNamee wrote:
> On 2009/05/13 11:11:45, Erik Corry wrote:
> > This doesn't work for our Debian non-EABI platform :-(
> 
> Do you have more info on how it failed?

So I found how it's done in Android's QEMU.

http://www.google.com/codesearch/p?hl=en#3snSSQMlsl0/cpu-exec.c

Builds for me with both versions of glibc.  Can you try on android?

Thanks

Powered by Google App Engine
This is Rietveld 408576698