Assert HttpNetWorkTransaction::GetResponseInfo() should never retun NULL when certificate error

net/http/http_cache.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache.h"
 
 #include <algorithm>
 
 #include "base/compiler_specific.h"
 
@@ skipping 920 matching lines @@
         // Truncate response data
         TruncateResponseData();
 
         // If this response is a redirect, then we can stop writing now.  (We
         // don't need to cache the response body of a redirect.)
         if (response_.headers->IsRedirect(NULL))
           DoneWritingToEntry(true);
       }
     }
   } else if (IsCertificateError(result)) {
-    response_.ssl_info = network_trans_->GetResponseInfo()->ssl_info;
+    const HttpResponseInfo* response = network_trans_->GetResponseInfo();
+    // If we get a certificate error, then there is a certificate in ssl_info,
+    // so GetResponseInfo() should never returns NULL here.
+    DCHECK(response);

[ukai, 2009/05/15 03:25:24]

Changed DCHECK here.

+    response_.ssl_info = response->ssl_info;
   }
   HandleResult(result);
 }
 
 void HttpCache::Transaction::OnNetworkReadCompleted(int result) {
   DCHECK(mode_ & WRITE || mode_ == NONE);
 
   if (revoked()) {
     HandleResult(ERR_UNEXPECTED);
     return;
@@ skipping 532 matching lines @@
     return;  // have to wait
 
   entry->pending_queue.erase(entry->pending_queue.begin());
 
   AddTransactionToEntry(entry, next);
 }
 
 //-----------------------------------------------------------------------------
 
 }  // namespace net