Refactor JumpTarget::Combine.

src/ia32/virtual-frame-ia32.h

Index: src/ia32/virtual-frame-ia32.h
===================================================================
--- src/ia32/virtual-frame-ia32.h	(revision 1927)
+++ src/ia32/virtual-frame-ia32.h	(working copy)
@@ -485,6 +485,18 @@
 
   bool Equals(VirtualFrame* other);
 
+  // Perform initialization required during entry frame computation
+  // after setting the virtual frame element at index in frame to be
+  // target.
+  void InitializeEntryElement(int index, FrameElement* target) {
+    elements_[index].clear_copied();
+    if (target->is_register()) {
+      register_locations_[target->reg().code()] = index;
+    } else if (target->is_copy()) {
+      elements_[target->index()].set_copied();
+    }

[Lasse Reichstein, 2009/05/13 10:23:30]

This function is identical to the one in virtual-frame-arm.h.
Perhaps it can be moved to a shared file?

[Kevin Millikin (Chromium), 2009/05/13 10:30:14]

Good point.  We have a TODO to combine the platform-specific virtual frame
header files into a single platform-independent one.  Once we do that, this
function will go there.

I'd rather not introduce yet another file (a shared virtual-frame-inl.h file) if
it will be only temporary.

+  }
+
   friend class JumpTarget;
 };