Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: src/jump-target.h

Issue 113329: Refactor JumpTarget::Combine. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 // return values using the virtual frame. 195 // return values using the virtual frame.
196 void DoJump(); 196 void DoJump();
197 void DoBranch(Condition cc, Hint hint); 197 void DoBranch(Condition cc, Hint hint);
198 void DoBind(int mergable_elements); 198 void DoBind(int mergable_elements);
199 199
200 private: 200 private:
201 // Add a virtual frame reaching this labeled block via a forward 201 // Add a virtual frame reaching this labeled block via a forward
202 // jump, and a fresh label for its merge code. 202 // jump, and a fresh label for its merge code.
203 void AddReachingFrame(VirtualFrame* frame); 203 void AddReachingFrame(VirtualFrame* frame);
204 204
205 // Choose an element from a pair of frame elements to be in the
206 // expected frame. Return null if they are incompatible.
207 FrameElement* Combine(FrameElement* left, FrameElement* right);
208
209 // Compute a frame to use for entry to this block. Mergable 205 // Compute a frame to use for entry to this block. Mergable
210 // elements is as described for the Bind function. 206 // elements is as described for the Bind function.
211 void ComputeEntryFrame(int mergable_elements); 207 void ComputeEntryFrame(int mergable_elements);
212 208
213 DISALLOW_COPY_AND_ASSIGN(JumpTarget); 209 DISALLOW_COPY_AND_ASSIGN(JumpTarget);
214 }; 210 };
215 211
216 212
217 // ------------------------------------------------------------------------- 213 // -------------------------------------------------------------------------
218 // Break targets 214 // Break targets
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 bool is_shadowing_; 312 bool is_shadowing_;
317 #endif 313 #endif
318 314
319 DISALLOW_COPY_AND_ASSIGN(ShadowTarget); 315 DISALLOW_COPY_AND_ASSIGN(ShadowTarget);
320 }; 316 };
321 317
322 318
323 } } // namespace v8::internal 319 } } // namespace v8::internal
324 320
325 #endif // V8_JUMP_TARGET_H_ 321 #endif // V8_JUMP_TARGET_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698