Issue 113329: Refactor JumpTarget::Combine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113329: Refactor JumpTarget::Combine. (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor JumpTarget::Combine. Committed: http://code.google.com/p/v8/source/detail?r=1930

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -90 lines)			Patch
M	src/arm/virtual-frame-arm.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.h	View	1	1 chunk	+12 lines, -0 lines	2 comments	Download
M	src/jump-target.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/jump-target.cc	View		3 chunks	+11 lines, -84 lines	0 comments	Download
M	src/virtual-frame.h	View		2 chunks	+28 lines, -2 lines	1 comment	Download
M	src/x64/virtual-frame-x64.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/113329/diff/16/17 File src/ia32/virtual-frame-ia32.h (right): http://codereview.chromium.org/113329/diff/16/17#newcode497 Line 497: } This function is identical to the ...

11 years, 7 months ago (2009-05-13 10:23:29 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-13 10:30:14 UTC) #3

http://codereview.chromium.org/113329/diff/16/17
File src/ia32/virtual-frame-ia32.h (right):

http://codereview.chromium.org/113329/diff/16/17#newcode497
Line 497: }
On 2009/05/13 10:23:30, Lasse Reichstein wrote:
> This function is identical to the one in virtual-frame-arm.h.
> Perhaps it can be moved to a shared file?

Good point.  We have a TODO to combine the platform-specific virtual frame
header files into a single platform-independent one.  Once we do that, this
function will go there.

I'd rather not introduce yet another file (a shared virtual-frame-inl.h file) if
it will be only temporary.

Expand Messages | Collapse Messages

Issue 113329: Refactor JumpTarget::Combine. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages