Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 113321: Stubs out OSExchangeData for views on gtk. (Closed)

Created:
11 years, 7 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Stubs out OSExchangeData for views on gtk. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16012

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -1079 lines) Patch
M app/os_exchange_data.h View 1 2 3 4 8 chunks +21 lines, -2 lines 0 comments Download
D app/os_exchange_data.cc View 1 2 1 chunk +0 lines, -706 lines 0 comments Download
A app/os_exchange_data_gtk.cc View 1 2 3 1 chunk +75 lines, -0 lines 0 comments Download
D app/os_exchange_data_unittest.cc View 1 2 1 chunk +0 lines, -365 lines 0 comments Download
A + app/os_exchange_data_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/os_exchange_data_win_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/build_config.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
I think I finally got this straightened out. app.vcproj isn't currently in this cl, but ...
11 years, 7 months ago (2009-05-13 19:35:20 UTC) #1
Ben Goodger (Google)
I do sort of wonder if it wouldn't be better to have OSExchangeDataWin as a ...
11 years, 7 months ago (2009-05-13 19:41:10 UTC) #2
sky
11 years, 7 months ago (2009-05-13 19:49:20 UTC) #3
On 2009/05/13 19:41:10, Ben Goodger wrote:
> I do sort of wonder if it wouldn't be better to have OSExchangeDataWin as a
> subclass of OSExchangeData to hold all the win-specific methods rather than
all
> the ifdefs.

I actually started down this route and after major headaches realized it wasn't
going to work. The problem is the reference counting needed on the windows side.
I would have to promote that to the superclass with implementations specific for
each platform. It seems wrong to promote the reference counting when it's only
needed on windows. It was a lot simpler to take this route.

  -Scott

Powered by Google App Engine
This is Rietveld 408576698