Issue 113303: Pass "gcl help upload" to upload.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113303: Pass "gcl help upload" to upload.py. (Closed)

Created:
11 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Pass "gcl help upload" to upload.py. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15911

Patch Set 1 #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	gcl.py	View		2 chunks	+10 lines, -3 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/113303/diff/1/2 File gcl.py (right): http://codereview.chromium.org/113303/diff/1/2#newcode561 Line 561: return Remove return and change if below to ...

11 years, 7 months ago (2009-05-12 21:25:45 UTC) #2

Evan Stade

http://codereview.chromium.org/113303/diff/1/2 File gcl.py (right): http://codereview.chromium.org/113303/diff/1/2#newcode561 Line 561: return On 2009/05/12 21:25:45, Lei Zhang wrote: > ...

11 years, 7 months ago (2009-05-12 21:53:20 UTC) #3

Lei Zhang

11 years, 7 months ago (2009-05-12 22:07:24 UTC) #4

LGTM

http://codereview.chromium.org/113303/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/113303/diff/1/2#newcode561
Line 561: return
On 2009/05/12 21:53:20, Evan Stade wrote:
> On 2009/05/12 21:25:45, Lei Zhang wrote:
> > Remove return and change if below to elif?
> 
> but then it would print two helps...

n/m, I have tunnel vision.

Expand Messages | Collapse Messages