Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1133004: Stop using O_EXCL by default when opening the device for writing. (Closed)

Created:
10 years, 9 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
tedbo
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Stop using O_EXCL by default when opening the device for writing. Using O_EXCL prevents the gpt tool from being able to modify any part of the GPT while there is a mounted filesystem on that drive. We need to be able to modify it so we can mark a newly upgraded image as bootable. Also updated the man page a bit, although it's still way out of sync.

Patch Set 1 #

Total comments: 1

Patch Set 2 : D'oh! Of course. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M boot.c View 2 chunks +2 lines, -3 lines 0 comments Download
M gpt.8 View 1 3 chunks +13 lines, -0 lines 0 comments Download
M gpt.c View 1 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Richardson
10 years, 9 months ago (2010-03-18 23:38:46 UTC) #1
tedbo
LGTM I don't want to hold up the gpt work, so this looks ok. I ...
10 years, 9 months ago (2010-03-18 23:45:45 UTC) #2
Bill Richardson
10 years, 9 months ago (2010-03-19 16:40:07 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698