Issue 113278: Simplify some functions by removing the options.stdout mock. Fix the unit tes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113278: Simplify some functions by removing the options.stdout mock. Fix the unit tes... (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly. Fix breakage caused by r15861 and add a regression test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15872

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -134 lines)			Patch
	M	gclient.py	View		36 chunks	+59 lines, -66 lines	0 comments	Download
	M	tests/gclient_test.py	View		24 chunks	+115 lines, -68 lines	0 comments	Download

Total messages: 2 (0 generated)

if it works, lgtm, as last time.