Issue 113270: Fix VS2008 build by adding a warning ignore....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113270: Fix VS2008 build by adding a warning ignore.... (Closed)

Created:
11 years, 7 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fix VS2008 build by adding a warning ignore. R=maruel BUG=2528 TEST=Building with VS2008 should succeed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15859

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View	1	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

Whoops -- the MP switch snuck in :) New snapshot uploaded.

11 years, 7 months ago (2009-05-12 16:29:09 UTC) #2

M-A Ruel

11 years, 7 months ago (2009-05-12 16:31:59 UTC) #3

lgtm

http://codereview.chromium.org/113270/diff/4/5
File build/common.gypi (right):

http://codereview.chromium.org/113270/diff/4/5#newcode380
Line 380: 'msvs_disabled_warnings': [4396, 4503, 4819],
I'd rather have it disabled only for WebCore but that's fine.

Expand Messages | Collapse Messages