Add more tests and cleanup ChangeInfo class.

Add more tests and cleanup ChangeInfo class.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15885

[sgk, 2009-05-12 18:37:48]

http://codereview.chromium.org/113269/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/113269/diff/1/2#newcode91
Line 91: if isinstance(output, list):
???  Hard-coded and non-obvious.  How does RunShell ever return a list here?  I
see it returning a "".join() or a p.stdout.read().

And if this really can happen on error, wouldn't it be better to call
RunShellWithReturnCode() and catch the error explicitly?

http://codereview.chromium.org/113269/diff/1/2#newcode349
Line 349: self.files = []
Preferred idiom:

if files is None:
  files = []
self.files = files

Otherwise, (new) code below that refers to the "files" variable might not
realize it's not affecting the self.files attribute.

[sgk, 2009-05-12 19:21:12]

lgtm