Issue 113268: Pull the copyright info out of the branding file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113268: Pull the copyright info out of the branding file. (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Pull the copyright info out of the branding file. BUG=11762 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15857

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	build/mac/tweak_app_infoplist	View	1	2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 7 months ago (2009-05-12 15:22:06 UTC) #2

lgtm

http://codereview.chromium.org/113268/diff/1/2
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/113268/diff/1/2#newcode1
Line 1: #!/bin/sh
I don't know what's actually changing here, but we're using the $'' string
syntax now, so this should be /bin/bash.

http://codereview.chromium.org/113268/diff/1/2#newcode61
Line 61: 
Extra blank line?

http://codereview.chromium.org/113268/diff/1/2#newcode90
Line 90: defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
I think NSHumanReadableCopyright should be set to ${COPYRIGHT_STRING} - it
shouldn't have the branding name and version in it.

Expand Messages | Collapse Messages