Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 113267: Reapply r1900, r1897, r1895 with a fix.... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reapply r1900, r1897, r1895 with a fix. When a paged space shrinks by an even multiple of the chunk size, ensure that the cached last page in the space is updated. Committed: http://code.google.com/p/v8/source/detail?r=1944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -91 lines) Patch
M src/heap.cc View 4 chunks +75 lines, -67 lines 0 comments Download
M src/spaces.h View 4 chunks +46 lines, -12 lines 0 comments Download
M src/spaces.cc View 4 chunks +16 lines, -8 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The bugfix is spaces.cc:734.
11 years, 7 months ago (2009-05-12 14:48:35 UTC) #1
Erik Corry
11 years, 7 months ago (2009-05-13 10:56:29 UTC) #2
I think the places where we access the last page variable we should (in debug
mode) traverse the pages and assert that the last page is the one stored in the
variable.

Otherwise LGTM.

Powered by Google App Engine
This is Rietveld 408576698