Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 113262: Revert r1900, r1897 and r1895 which are all gc changes. The changes... (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert r1900, r1897 and r1895 which are all gc changes. The changes to the page iterator leads to occasional crashes in tests. Committed: http://code.google.com/p/v8/source/detail?r=1915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -141 lines) Patch
M src/heap.cc View 4 chunks +67 lines, -75 lines 0 comments Download
M src/spaces.h View 4 chunks +12 lines, -46 lines 0 comments Download
M src/spaces.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 7 months ago (2009-05-12 12:57:28 UTC) #1
Kevin Millikin (Chromium)
11 years, 7 months ago (2009-05-12 12:59:42 UTC) #2
Unfortunately LGTM.

Powered by Google App Engine
This is Rietveld 408576698