Issue 113261: X64: Added stubs for unimplemented disassembler functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113261: X64: Added stubs for unimplemented disassembler functions. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee

CC:
v8-dev

Visibility:
Public.

Description

X64: Added stubs for unimplemented disassembler functions.

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	src/x64/disasm-x64.cc	View		1 chunk	+35 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 7 months ago (2009-05-12 12:59:46 UTC) #2

Ok

http://codereview.chromium.org/113261/diff/1/2
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/113261/diff/1/2#newcode59
Line 59: Disassembler::~Disassembler() {}
put this w/ the constructor.

http://codereview.chromium.org/113261/diff/1/2#newcode62
Line 62: }  // end namespace disasm
I think you just mean "// namespace disasm"

Expand Messages | Collapse Messages