Issue 113245: Remove unused kWindowTilePixels from browser.cc...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113245: Remove unused kWindowTilePixels from browser.cc... (Closed)

Created:
11 years, 7 months ago by yuzo

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove unused kWindowTilePixels from browser.cc window_sizer.cc has a constant with the same name, which is in use. The one in browser.cc should be removed to avoid confusion. (Split from Issue 115180)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yuzo

On 2009/05/12 02:08:31, yuzo wrote: > Hi, Peter, > > Can you review this? > ...

11 years, 7 months ago (2009-05-12 06:10:11 UTC) #2

yuzo

Hi, Peter, Can you commit this? Yuzo On 2009/05/12 18:38:27, pkasting wrote: > LGTM

11 years, 7 months ago (2009-05-19 06:44:23 UTC) #4

yuzo

11 years, 7 months ago (2009-05-20 05:11:53 UTC) #6

Thank you!!

I'll close this issue shortly.

On 2009/05/19 20:50:00, pkasting wrote:
> Landed in r16411.

Expand Messages | Collapse Messages