Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/test/startup/feature_startup_test.cc

Issue 113229: Add new tab startup test to the linux & mac build. (Closed)
Patch Set: make the test actually run Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/automation/automation_provider.cc ('K') | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/startup/feature_startup_test.cc
diff --git a/chrome/test/startup/feature_startup_test.cc b/chrome/test/startup/feature_startup_test.cc
index b1a22f4d86b3e0c387fd0cdb07643bc9bab651d5..2d86b4bf0498b254893efd45d5d8c28e1b04f805 100644
--- a/chrome/test/startup/feature_startup_test.cc
+++ b/chrome/test/startup/feature_startup_test.cc
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <windows.h>
-
-#include "app/win_util.h"
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/perftimer.h"
@@ -21,12 +18,12 @@ namespace {
// Returns the directory name where the "typical" user data is that we use for
// testing.
-std::wstring ComputeTypicalUserDataSource() {
- std::wstring source_history_file;
+FilePath ComputeTypicalUserDataSource() {
+ FilePath source_history_file;
EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA,
&source_history_file));
- file_util::AppendToPath(&source_history_file, L"profiles");
- file_util::AppendToPath(&source_history_file, L"typical_history");
+ source_history_file = source_history_file.AppendASCII("profiles")
+ .AppendASCII("typical_history");
return source_history_file;
}
@@ -54,7 +51,7 @@ class NewTabUIStartupTest : public UITest {
// we should report cold timings.
void RunStartupTest(const char* label, bool want_warm, bool important) {
// Install the location of the test profile file.
- set_template_user_data(ComputeTypicalUserDataSource());
+ set_template_user_data(ComputeTypicalUserDataSource().ToWStringHack());
TimeDelta timings[kNumCycles];
for (int i = 0; i < kNumCycles; ++i) {
« chrome/browser/automation/automation_provider.cc ('K') | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698