Issue 113229: Add new tab startup test to the linux & mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113229: Add new tab startup test to the linux & mac build. (Closed)

Created:
11 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add new tab startup test to the linux & mac build.

Patch Set 2 : make the test actually run #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -16 lines)			Patch
M	base/test_file_util_posix.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/test/startup/feature_startup_test.cc	View	1	3 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/113229/diff/1/3 File chrome/test/startup/feature_startup_test.cc (right): http://codereview.chromium.org/113229/diff/1/3#newcode25 Line 25: source_history_file = source_history_file.AppendASCII("profiles"); source_history_file = source_history_file.AppendASCII("profiles") .AppendASCII("typical_history") ...

11 years, 7 months ago (2009-05-11 22:25:32 UTC) #2

tony

Fixed. Also, I ran the new tab startup test and it was hanging. This new ...

11 years, 7 months ago (2009-05-11 23:08:24 UTC) #3