Issue 113197: Fix bug 344: always keep attributes of existing properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113197: Fix bug 344: always keep attributes of existing properties. (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix bug 344: always keep attributes of existing properties. Committed: http://code.google.com/p/v8/source/detail?r=1931

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -91 lines)			Patch
M	src/objects.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
D	test/mjsunit/bugs/bug-334.js	View	1 chunk	+0 lines, -90 lines	0 comments	Download
A +	test/mjsunit/regress/regress-334.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

Christian Plesner Hansen

Isn't this the exact opposite of what we talked about? That property attributes should be ...

11 years, 7 months ago (2009-05-12 07:48:07 UTC) #2

Lgtm