- Represent strings internally in UTF-16 format, this makes it

lib/compiler/implementation/js_backend/constant_emitter.dart

Index: lib/compiler/implementation/js_backend/constant_emitter.dart
===================================================================
--- lib/compiler/implementation/js_backend/constant_emitter.dart	(revision 14156)
+++ lib/compiler/implementation/js_backend/constant_emitter.dart	(working copy)
@@ -110,7 +110,7 @@
       } else if (identical(code, $BACKSLASH)) {
         buffer.add(r'\\');
       } else {
-        if (code > 0xffff) {
+        if (code >= 0xD800 && code <= 0xDFFF) {

[ahe, 2012/10/28 12:07:02]

I think you should just remove this check. If the invariant now is that
string.iterator returns a sequence UTF-16 code units, then this should just pass
unmodified through to JavaScript.

[siva, 2012/10/31 01:21:26]

I have decided to drop the change and instead created bug
6418 reflecting the issue with two tests that fail when dart2js tests are run
with a VM that represents strings in UTF-16 format.

On 2012/10/28 12:07:02, ahe wrote:

           compiler.reportError(
               diagnosticNode,
               'Unhandled non-BMP character: U+${code.toRadixString(16)}');