cros: Allow default app order to be loaded from an external file.

chrome/browser/chromeos/extensions/default_app_order.cc

Index: chrome/browser/chromeos/extensions/default_app_order.cc
diff --git a/chrome/browser/chromeos/extensions/default_app_order.cc b/chrome/browser/chromeos/extensions/default_app_order.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8df79c2be2cd232c445906e0750e52139c9948b0
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/default_app_order.cc
@@ -0,0 +1,142 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/extensions/default_app_order.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/json/json_file_value_serializer.h"
+#include "base/path_service.h"
+#include "base/time.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/extensions/extension_constants.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace chromeos {
+namespace default_app_order {
+
+namespace {
+
+// Timeout in seconds to wait for the ordinals file to be loaded.
+const int kTimeoutSecs = 3;
+
+// The single ExternalLoader instance.
+ExternalLoader* loader_instance = NULL;
+
+// Reads external ordinal json file and returned the parsed value. Returns NULL
+// if the file does not exist or could not be parsed properly. Caller takes
+// ownership of the returned value.
+base::ListValue* ReadExternalOrdinalFile(const FilePath& path) {
+  if (!file_util::PathExists(path))
+    return NULL;
+
+  JSONFileValueSerializer serializer(path);
+  std::string error_msg;
+  base::Value* value = serializer.Deserialize(NULL, &error_msg);
+  if (!value) {
+    LOG(WARNING) << "Unable to deserialize default app ordinals json data:"
+        << error_msg << ", file=" << path.value();
+    return NULL;
+  }
+
+  base::ListValue* ordinal_list_value = NULL;
+  if (value->GetAsList(&ordinal_list_value))
+    return ordinal_list_value;
+
+  LOG(WARNING) << "Expect a JSON list in file " << path.value();
+  return NULL;
+}
+
+// Gets built-in default app order.
+void GetDefault(std::vector<std::string>* app_ids) {
+  DCHECK(app_ids && app_ids->empty());
+
+  const char* kDefaultAppOrder[] = {
+    extension_misc::kChromeAppId,
+    extension_misc::kWebStoreAppId,
+    "coobgpohoikkiipiblmjeljniedjpjpf",  // Search
+    "blpcfgokakmgnkcojhhkbfbldkacnbeo",  // Youtube
+    "pjkljhegncpnkpknbcohdijeoejaedia",  // Gmail
+    "ejjicmeblgpmajnghnpcppodonldlgfn",  // Calendar
+    "kjebfhglflhjjjiceimfkgicifkhjlnm",  // Scratchpad
+    "lneaknkopdijkpnocmklfnjbeapigfbh",  // Google Maps
+    "apdfllckaahabafndbhieahigkjlhalf",  // Drive
+    "aohghmighlieiainnegkcijnfilokake",  // Docs
+    "felcaaldnbdncclmgdcncolpebgiejap",  // Sheets
+    "aapocclcgogkmnckokdopfmhonfmgoek",  // Slides
+    "dlppkpafhbajpcmmoheippocdidnckmm",  // Google+
+    "kbpgddbgniojgndnhlkjbkpknjhppkbk",  // Google+ Hangouts
+    "hhaomjibdihmijegdhdafkllkbggdgoj",  // Files
+    "hkhhlkdconhgemhegnplaldnmnmkaemd",  // Tips & Tricks
+    "icppfcnhkcmnfdhfhphakoifcfokfdhg",  // Play Music
+    "mmimngoggfoobjdlefbcabngfnmieonb",  // Play Books
+    "fppdphmgcddhjeddoeghpjefkdlccljb",  // Play Movies
+    "fobcpibfeplaikcclojfdhfdmbbeofai",  // Games
+    "joodangkbfjnajiiifokapkpmhfnpleo",  // Calculator
+    "hfhhnacclhffhdffklopdkcgdhifgngh",  // Camera
+    "gbchcmhmhahfdphkhkmpfmihenigjmpp",  // Chrome Remote Desktop
+  };
+
+  for (size_t i = 0; i < arraysize(kDefaultAppOrder); ++i)
+    app_ids->push_back(std::string(kDefaultAppOrder[i]));
+}
+
+}  // namespace
+
+ExternalLoader::ExternalLoader() : loaded_(true, false) {

[tbarzic, 2012/10/26 21:56:28]

nit: a comment whet true and false mean.

[xiyuan, 2012/10/26 22:39:25]

Done.

+  DCHECK(!loader_instance);
+  loader_instance = this;
+
+  content::BrowserThread::PostBlockingPoolTask(FROM_HERE,
+      base::Bind(&ExternalLoader::LoadOnBlockingPool,
+                 base::Unretained(this)));

[tbarzic, 2012/10/26 21:56:28]

can blocking pool still be running while this is destructed? (my guess is no,
but I'm not completely sure)

[xiyuan, 2012/10/26 22:39:25]

Right now, the only ExternalLoader instance is owned by
ChromeBrowserMainPartsChromeos and get released after blocking pool shuts down.

Added a DCHECK in dtor to make sure that the posted task has run when
destructing this class. This should avoid future regressions when we instantiate
it elsewhere.

+}
+
+ExternalLoader::~ExternalLoader() {
+  DCHECK_EQ(loader_instance, this);
+  loader_instance = NULL;
+}
+
+bool ExternalLoader::IsLoaded() {
+  return loaded_.IsSignaled();
+}
+
+void ExternalLoader::WaitForLoad() {
+  CHECK(loaded_.TimedWait(base::TimeDelta::FromSeconds(kTimeoutSecs)));
+}
+
+void ExternalLoader::LoadOnBlockingPool() {
+  FilePath ordinals_file;
+  CHECK(PathService::Get(chrome::FILE_DEFAULT_APP_ORDER, &ordinals_file));
+
+  scoped_ptr<base::ListValue> ordinals_value(
+      ReadExternalOrdinalFile(ordinals_file));
+  if (ordinals_value) {
+    for (size_t i = 0; i < ordinals_value->GetSize(); ++i) {
+      std::string app_id;
+      CHECK(ordinals_value->GetString(i, &app_id));
+      app_ids_.push_back(app_id);
+    }
+  } else {
+    GetDefault(&app_ids_);
+  }
+
+  loaded_.Signal();
+}
+
+void Get(std::vector<std::string>* app_ids) {
+  // |loader_instance| could be NULL for test.
+  if (!loader_instance) {
+    GetDefault(app_ids);
+    return;
+  }
+
+  CHECK(loader_instance->IsLoaded());
+  *app_ids = loader_instance->app_ids();
+}
+
+}  // namespace default_app_order
+}  // namespace chromeos