Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: remoting/host/remoting_me2me_host.cc

Issue 11316010: Fix AudioCapturer implementation to read from audio pipe even when there are no active clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/remoting_me2me_host.cc
diff --git a/remoting/host/remoting_me2me_host.cc b/remoting/host/remoting_me2me_host.cc
index 6291e4189f4a112a7b726b00a09c22cdfd7a3bb6..092c0f745e012019682bb277b611cfb2fccbf057 100644
--- a/remoting/host/remoting_me2me_host.cc
+++ b/remoting/host/remoting_me2me_host.cc
@@ -444,6 +444,21 @@ void HostProcess::StartHostProcess() {
return;
}
+#if defined(OS_LINUX)
+ // TODO(sergeyu): Pass configuration parameters to the Linux-specific version
+ // of DesktopEnvironmentFactory when we have it.
+ remoting::VideoFrameCapturer::EnableXDamage(true);
+
+ // Initialize AudioCapturer with the pipe name we get in command line and
+ // provide it with a task runner for the thread it should work on.
Wez 2012/10/31 00:56:28 nit: Suggest "If an audio pipe is specific on the
Sergey Ulanov 2012/10/31 18:41:24 Done.
+ FilePath audio_pipe_name = CommandLine::ForCurrentProcess()->
+ GetSwitchValuePath(kAudioPipeSwitchName);
+ if (!audio_pipe_name.empty()) {
+ remoting::AudioCapturerLinux::InitializePipeReader(
+ context_->audio_task_runner(), audio_pipe_name);
+ }
+#endif // defined(OS_LINUX)
+
// Create a desktop environment factory appropriate to the build type &
// platform.
#if defined(OS_WIN)
@@ -897,14 +912,6 @@ int main(int argc, char** argv) {
new remoting::AutoThreadTaskRunner(message_loop.message_loop_proxy(),
quit_message_loop)));
-#if defined(OS_LINUX)
- // TODO(sergeyu): Pass configuration parameters to the Linux-specific version
- // of DesktopEnvironmentFactory when we have it.
- remoting::VideoFrameCapturer::EnableXDamage(true);
- remoting::AudioCapturerLinux::SetPipeName(CommandLine::ForCurrentProcess()->
- GetSwitchValuePath(kAudioPipeSwitchName));
-#endif // defined(OS_LINUX)
-
if (!context->Start())
return remoting::kInitializationFailed;

Powered by Google App Engine
This is Rietveld 408576698