Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 113152: Add a simple dmg script to the mac build dir to build a dmg out of the app.... (Closed)

Created:
11 years, 7 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a simple dmg script to the mac build dir to build a dmg out of the app. Add a target to build a dmg out of the app. Add a target to all that will build everything and the dmg (since we don't include the dmg in all since developers really don't need to wait for that). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15672

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -2 lines) Patch
M build/all.gyp View 2 chunks +12 lines, -2 lines 0 comments Download
A build/mac/build_app_dmg View 1 chunk +37 lines, -0 lines 1 comment Download
M chrome/chrome.gyp View 2 chunks +29 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
TVL
even though i setup the inputs/outputs, it always runs, probably because of the script step ...
11 years, 7 months ago (2009-05-08 16:47:17 UTC) #1
Mark Mentovai
11 years, 7 months ago (2009-05-08 20:18:22 UTC) #2
lg, and we can work on the overbuild problem once it's in.

http://codereview.chromium.org/113152/diff/1/2
File build/mac/build_app_dmg (right):

http://codereview.chromium.org/113152/diff/1/2#newcode19
Line 19: set -ex
Maybe don't set -x 'til you call pkg-dmg.  We don't really care to display
what's being assinged, do we?  Same goes for -e because the sets can't really
fail.

http://codereview.chromium.org/113152/diff/1/4
File chrome/chrome.gyp (right):

http://codereview.chromium.org/113152/diff/1/4#newcode2803
Line 2803: 'build_app_dmg_script': '<(DEPTH)/build/mac/build_app_dmg',
The varname should end with _file or _path for proper rehoming.

Powered by Google App Engine
This is Rietveld 408576698