Issue 113144: Move the right dependencies into the main section of all.gyp,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113144: Move the right dependencies into the main section of all.gyp,... (Closed)

Created:
11 years, 7 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the right dependencies into the main section of all.gyp, the {test_shell,webkit}.gyp:* targets from the 'all_gyps' section, not the specific 'test_shell' and 'test_shell_tests' targets from the mac condition. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15629

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	build/all.gyp	View		3 chunks	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 7 months ago (2009-05-08 13:24:26 UTC) #3

LG

http://codereview.chromium.org/113144/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/113144/diff/1/2#newcode43
Line 43: '../webkit/tools/test_shell/test_shell.gyp:*',
This may pull a couple extra targets into "all" that weren't there before
(test_worker on Linux?) but that's probably OK.

Expand Messages | Collapse Messages