Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 113143: Move color_utils, text_elider, drag_utils, accessibility_types, standard_layo... (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move color_utils, text_elider, drag_utils, accessibility_types, standard_layout to new locations in app/ and views/ http://crbug.com/11387

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -1970 lines) Patch
M app/DEPS View 3 1 chunk +4 lines, -1 line 0 comments Download
M app/app.vcproj View 1 2 3 1 chunk +263 lines, -247 lines 0 comments Download
A + app/gfx/color_utils.h View 3 2 chunks +4 lines, -4 lines 0 comments Download
A + app/gfx/color_utils.cc View 3 1 chunk +3 lines, -5 lines 0 comments Download
A + app/gfx/text_elider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + app/gfx/text_elider_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser.vcproj View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/debugger/debugger_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/drag_utils.h View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/drag_utils.cc View 1 2 3 1 chunk +0 lines, -161 lines 0 comments Download
M chrome/browser/input_window_dialog_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jsmessage_box_handler.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/page_overlays.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printed_document.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_entry.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/toolbar_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/about_ipc_dialog.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/about_network_dialog.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 2 3 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_editor_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/browser_views.vcproj View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/views/bug_report_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/clear_browsing_data.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/edit_keyword_controller.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_customize_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view_base.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/hung_renderer_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/importer_lock_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importer_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/importing_progress_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/keyword_editor_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/login_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/advanced_page_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/cookies_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/exceptions_page_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/options/options_group_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/passwords_page_view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/passwords_page_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/page_info_window.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/select_profile_dialog.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/views/standard_layout.h View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 8 chunks +7 lines, -7 lines 0 comments Download
D chrome/common/accessibility_types.h View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/common/common.vcproj View 1 2 3 3 chunks +0 lines, -20 lines 0 comments Download
D chrome/common/gfx/color_utils.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/gfx/color_utils.cc View 1 2 3 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/common/gfx/text_elider.h View 1 2 3 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/common/gfx/text_elider.cc View 1 2 3 1 chunk +0 lines, -517 lines 0 comments Download
D chrome/common/gfx/text_elider_unittest.cc View 1 2 3 1 chunk +0 lines, -267 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M views/DEPS View 1 2 3 1 chunk +24 lines, -37 lines 0 comments Download
A + views/accessibility/accessibility_types.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M views/accessibility/view_accessibility.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M views/controls/label.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/chrome_menu.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M views/controls/message_box_view.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + views/drag_utils.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + views/drag_utils.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
A + views/standard_layout.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M views/view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/views.vcproj View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download
M views/widget/tooltip_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/window/dialog_client_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
11 years, 7 months ago (2009-05-08 07:51:24 UTC) #1
Ben Goodger (Google)
11 years, 7 months ago (2009-05-08 21:02:36 UTC) #2
sky
11 years, 7 months ago (2009-05-08 21:03:45 UTC) #3
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698