Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11314020: Allow Caps Lock to be remapped [part 1 of 2] (Closed)

Created:
8 years, 1 month ago by Yusuke Sato
Modified:
8 years, 1 month ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, mazda
Visibility:
Public.

Description

Allow Caps Lock to be remapped [part 1 of 2]. * Add "settings.language.remap_caps_lock_key_to" user pref. * Modify EventRewriter so it rewrites F16 and/or Mod3Mask following the new pref. * Modify keyboard_overlay.html so it shows a drop-down menu for Caps Lock. This part is currently commented out. This change depends on https://gerrit.chromium.org/gerrit/#/c/36885/. BUG=146204 TEST=new tests added TEST=manually confirmed that F15 still works as Control, Caps Lock works as Caps Lock. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165191

Patch Set 1 : review #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -47 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/keyboard_overlay.html View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 8 chunks +29 lines, -39 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 7 chunks +53 lines, -8 lines 2 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Please take a look.
8 years, 1 month ago (2012-10-30 18:01:02 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/ash/event_rewriter_unittest.cc File chrome/browser/ui/ash/event_rewriter_unittest.cc (right): http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/ash/event_rewriter_unittest.cc#newcode1487 chrome/browser/ui/ash/event_rewriter_unittest.cc:1487: // TODO(yusukes): Reenable the test once build servers ...
8 years, 1 month ago (2012-10-30 18:16:34 UTC) #2
mazda
drive-by comment http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc File chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc (right): http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc#newcode316 chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc:316: // TODO(mazda): Support prefs::kLanguageRemapCapsLockKeyTo once Caps Lock ...
8 years, 1 month ago (2012-10-30 18:26:03 UTC) #3
Yusuke Sato
Ben, could you do an owner review? http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/ash/event_rewriter_unittest.cc File chrome/browser/ui/ash/event_rewriter_unittest.cc (right): http://codereview.chromium.org/11314020/diff/14003/chrome/browser/ui/ash/event_rewriter_unittest.cc#newcode1487 chrome/browser/ui/ash/event_rewriter_unittest.cc:1487: // TODO(yusukes): ...
8 years, 1 month ago (2012-10-30 19:11:33 UTC) #4
Ben Goodger (Google)
lgtm
8 years, 1 month ago (2012-10-31 16:07:40 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-31 16:21:01 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698