Issue 113123: Fleshes out WidgetGTK and WindowGTK a bit more. This is still vary...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113123: Fleshes out WidgetGTK and WindowGTK a bit more. This is still vary... (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fleshes out WidgetGTK and WindowGTK a bit more. This is still vary rough, but makes things work a bit more. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15598

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+615 lines, -95 lines)			Patch
M	build/build_config.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/views/controls/button/native_button.cc	View	4 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/views/controls/button/native_button_wrapper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/views/event.h	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/views/event_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/views/widget/root_view.h	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	chrome/views/widget/root_view_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/views/widget/widget_gtk.h	View	5 chunks	+46 lines, -11 lines	0 comments	Download
M	chrome/views/widget/widget_gtk.cc	View	12 chunks	+173 lines, -51 lines	1 comment	Download
M	chrome/views/window/client_view.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/views/window/custom_frame_view.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
A	chrome/views/window/hit_test.h	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/views/window/non_client_view.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/views/window/window_delegate.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/views/window/window_gtk.h	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	chrome/views/window/window_gtk.cc	View	1 chunk	+199 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 7 months ago (2009-05-07 22:25:29 UTC) #2

LGTM, plus one warning:

http://codereview.chromium.org/113123/diff/1/7
File chrome/views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/113123/diff/1/7#newcode129
Line 129: gtk_fixed_move(GTK_FIXED(child_widget_parent_), child, x, y);
(General issue; doesn't block this patch.)

If you're going to use a GtkFixed, make sure you disable all of GTK's theming
systems because they *will* change your native widgets sizes behind your back.

Expand Messages | Collapse Messages