build/android/pylib/base_test_runner.py - Issue 11312239: Modify the Android test running scripts so they can be used from WebKit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/base_test_runner.py

Issue 11312239: Modify the Android test running scripts so they can be used from WebKit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/base_test_runner.py

diff --git a/build/android/pylib/base_test_runner.py b/build/android/pylib/base_test_runner.py

index 5355633282658f15820e5890e704b89b67419f42..5073587712dc76833461f7205adf3851396689cc 100644

--- a/build/android/pylib/base_test_runner.py

+++ b/build/android/pylib/base_test_runner.py

@@ -106,9 +106,11 @@ class BaseTestRunner(object):

dest_dir: Absolute path to copy to on the device.

"""

for p in test_data_paths:

+ if not isinstance(p, list):

bulach 2012/11/15 01:06:39 uh? 103 doesn't say this is allowed, who's passing

Peter Beverloo 2012/11/15 12:11:29 See single_test_runner.py:241; removed.

+ p = [p, p]

self.adb.PushIfNeeded(

- os.path.join(constants.CHROME_DIR, p),

- os.path.join(dest_dir, p))

+ os.path.join(constants.CHROME_DIR, p[0]),

+ os.path.join(dest_dir, p[1]))

def LaunchTestHttpServer(self, document_root, port=None,

extra_config_contents=None):

« no previous file with comments | « build/android/pylib/android_commands.py ('k') | build/android/pylib/cmd_helper.py » ('j') | build/android/pylib/cmd_helper.py » ('J')