Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 11312195: webkit/ppapi: Notify the container when a plugin is accepting wheel events just like r143871. (Closed)

Created:
8 years, 1 month ago by Yusuke Sato
Modified:
8 years ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

webkit/ppapi: Notify the container when a plugin is accepting wheel events just like r143871. Otherwise, the container might not be able to receive wheel events in some cases (e.g. when threaded compositing is in use). BUG=158506 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169530

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : rebase, address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 6 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
James, Could you have a look at the Chrome part as well?
8 years, 1 month ago (2012-11-20 17:52:41 UTC) #1
jamesr
lgtm but could be a bit cleaner, IMO https://codereview.chromium.org/11312195/diff/2001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): https://codereview.chromium.org/11312195/diff/2001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode2150 webkit/plugins/ppapi/ppapi_plugin_instance.cc:2150: container_->setWantsWheelEvents(IsAcceptingWheelEvents()); ...
8 years ago (2012-11-26 06:23:07 UTC) #2
Yusuke Sato
https://codereview.chromium.org/11312195/diff/2001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): https://codereview.chromium.org/11312195/diff/2001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode2150 webkit/plugins/ppapi/ppapi_plugin_instance.cc:2150: container_->setWantsWheelEvents(IsAcceptingWheelEvents()); On 2012/11/26 06:23:07, jamesr wrote: > this little ...
8 years ago (2012-11-26 23:22:18 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-26 23:27:49 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698